fix(sqlite): escape SQL identifiers and literals in metadata/DDL paths (#1914) - #2204
Merged
Conversation
…intainer review (OtterMind#1914) - SqliteIdentifierProcessor gains INSTANCE, escapeString (single-quote doubling) and static escapeIdentifier; quoteIdentifier overloads delegate - SqliteMetaData/DBManager use getSQLIdentifierProcessor()/INSTANCE - builders/enums use SqliteIdentifierProcessor.escapeIdentifier - non-escapable validation moved to SqliteSqlGuards (safe names, type names, column defaults, line comments) - SqliteSqlEscapes removed; tests migrated (16 green)
openai0229
force-pushed
the
fix/sqli2-sqlite
branch
from
July 29, 2026 10:02
ecf213b to
9724d61
Compare
openai0229
approved these changes
Jul 29, 2026
openai0229
left a comment
Contributor
There was a problem hiding this comment.
Maintainer verification completed against the shared identifier round-trip contract and SQLite generated-SQL paths. Clean 9-module reactor passed; SQLite tests 22/22. No blocking findings.
openai0229
approved these changes
Jul 29, 2026
openai0229
left a comment
Contributor
There was a problem hiding this comment.
Maintainer review complete. SQLite identifier/literal escaping, structural type/default guards, inherited builder paths, regression tests, and local sqlite3 execution were revalidated on the latest main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1914
Summary
Completes the SQLite database-plugin portion of the identifier and literal escaping work.
strftime(...)andjson_extract(...).--comments, and keeps null database qualifiers out of generated SQL.FROMrather than the malformed sharedFROM whereconstant.Affected surfaces
Verification
mvn -B -f chat2db-community-server/pom.xml -pl chat2db-community-plugins/chat2db-community-sqlite -am clean test -DskipTests=false -Dmaven.test.skip=false -Dsurefire.failIfNoSpecifiedTests=falseBUILD SUCCESSacross 9 reactor modules; 791 tests passed in tested modules, including SQLite22/22, MySQL653/653, SPI90/90, and tools26/26.git diff --check origin/main...HEAD: passed.CREATE TABLE,INSERT,UPDATE,CREATE INDEX, andSELECTstatements with/usr/bin/sqlite3 :memory:; the final query returnedupdated.Risk and compatibility
ISQLIdentifierProcessorcontract.Reviewer map
SqliteIdentifierProcessor,SqliteSqlGuards, thenSqliteBuilder,SqliteMetaData,SqliteDBManager, and the type/index enums.Contributor declaration
AI assistance: Substantial AI-assisted maintainer revision, multi-agent review, and test expansion; all final changes were source-reviewed and verified with the commands above.